walterddr commented on code in PR #11268:
URL: https://github.com/apache/pinot/pull/11268#discussion_r1285114218


##########
pinot-query-planner/src/main/java/org/apache/calcite/sql/fun/PinotOperatorTable.java:
##########
@@ -75,6 +73,14 @@ public static synchronized PinotOperatorTable instance() {
    * which are multistage enabled.
    */
   public final void initNoDuplicate() {
+    // Pinot supports native COALESCE function, thus no need to create CASE 
WHEN conversion.
+    register(new PinotSqlCoalesceFunction());
+    // Ensure ArrayValueConstructor is registered before ArrayQueryConstructor
+    register(ARRAY_VALUE_CONSTRUCTOR);
+    // Ensure MapValueConstructor is registered before MapQueryConstructor
+    register(MAP_VALUE_CONSTRUCTOR);

Review Comment:
   We can do map constructor later 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to