Jackie-Jiang commented on code in PR #11246:
URL: https://github.com/apache/pinot/pull/11246#discussion_r1284052209
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/TlsUtils.java:
##########
@@ -240,10 +230,6 @@ public static void installDefaultSSLSocketFactory(String
keyStoreType, String ke
// HttpsURLConnection
HttpsURLConnection.setDefaultSSLSocketFactory(sc.getSocketFactory());
- // Apache HTTP client 3.x
- Protocol.registerProtocol("https",
- new Protocol(CommonConstants.HTTPS_PROTOCOL, new
PinotProtocolSocketFactory(sc.getSocketFactory()), 443));
Review Comment:
Hmm, in that case should we remove this as the last cleanup step instead of
first? We haven't started cleaning up other usages yet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
