shenyu0127 commented on code in PR #11261:
URL: https://github.com/apache/pinot/pull/11261#discussion_r1283973015


##########
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/FilterOperatorUtils.java:
##########
@@ -73,7 +78,7 @@ public BaseFilterOperator getLeafFilterOperator(QueryContext 
queryContext, Predi
       if (predicateEvaluator.isAlwaysFalse()) {
         return EmptyFilterOperator.getInstance();
       } else if (predicateEvaluator.isAlwaysTrue()) {
-        return new MatchAllFilterOperator(numDocs);
+        return new MatchAllFilterOperator(queryContext, dataSource, numDocs);

Review Comment:
   Your suggestion is a cleaner solution.
   
   Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to