Jackie-Jiang commented on code in PR #11234:
URL: https://github.com/apache/pinot/pull/11234#discussion_r1283959599
##########
pinot-query-planner/src/test/resources/queries/PinotHintablePlans.json:
##########
@@ -1,33 +1,19 @@
{
"pinot_hint_option_tests": {
"queries": [
- {
- "description": "SELECT * inner join with filter on one table",
- "sql": "EXPLAIN PLAN FOR SELECT /*+
joinOptions(is_colocated_by_join_keys='true') */ * FROM a JOIN b ON a.col1 =
b.col2 WHERE a.col3 >= 0",
- "output": [
- "Execution Plan",
- "\nLogicalJoin(condition=[=($0, $8)], joinType=[inner])",
- "\n PinotLogicalExchange(distribution=[single])",
- "\n LogicalFilter(condition=[>=($2, 0)])",
- "\n LogicalTableScan(table=[[a]])",
- "\n PinotLogicalExchange(distribution=[single])",
- "\n LogicalTableScan(table=[[b]])",
- "\n"
- ]
- },
{
"description": "Inner join with group by",
- "sql": "EXPLAIN PLAN FOR SELECT /*+
joinOptions(is_colocated_by_join_keys='true'),
aggOptions(is_partitioned_by_group_by_keys='true') */a.col1, AVG(b.col3) FROM a
JOIN b ON a.col1 = b.col2 WHERE a.col3 >= 0 AND a.col2 = 'a' AND b.col3 < 0
GROUP BY a.col1",
+ "sql": "EXPLAIN PLAN FOR SELECT /*+
aggOptions(is_partitioned_by_group_by_keys='true') */ a.col1, AVG(b.col3) FROM
a JOIN b ON a.col1 = b.col2 WHERE a.col3 >= 0 AND a.col2 = 'a' AND b.col3 < 0
GROUP BY a.col1",
Review Comment:
The reason why I didn't add plan test for this hint is because this hint is
not applied during the planning time, so the plan is always the same
with/without the hint
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
