vvivekiyer commented on code in PR #11151: URL: https://github.com/apache/pinot/pull/11151#discussion_r1282517498
########## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/BaseClusterIntegrationTestSet.java: ########## @@ -146,6 +146,19 @@ private void testHardcodedQueriesCommon() String query; String h2Query; + // SUM result will overflow INTEGER + query = "SELECT SUM(ActualElapsedTime) FROM mytable"; + + // SUM result will overflow INTEGER + query = "SELECT SUM(CAST(ActualElapsedTime AS FLOAT)) FROM mytable"; + + // SUM result will overflow INTEGER + query = "SELECT SUM(CAST(ActualElapsedTime AS BIGINT)) FROM mytable"; + + // SUM result will overflow INTEGER + query = "SELECT SUM(CAST(ActualElapsedTime AS DOUBLE)) FROM mytable"; + + testQuery(query); Review Comment: Is there a runtime test that verifies SUM (and other aggregations) on BIG_DECIMAL column? I remember testing this long back and there were some issues. Not sure if they've been fixed now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org