Aravind-Suresh commented on code in PR #11183:
URL: https://github.com/apache/pinot/pull/11183#discussion_r1281277544
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -170,11 +172,13 @@ public class PinotLLCRealtimeSegmentManager {
private final int _deepstoreUploadRetryTimeoutMs;
private final FileUploadDownloadClient _fileUploadDownloadClient;
private final AtomicInteger _numCompletingSegments = new AtomicInteger(0);
+ private final Executor _executor;
+ private final HttpConnectionManager _connectionManager;
private volatile boolean _isStopping = false;
public PinotLLCRealtimeSegmentManager(PinotHelixResourceManager
helixResourceManager, ControllerConf controllerConf,
- ControllerMetrics controllerMetrics) {
+ ControllerMetrics controllerMetrics, Executor executor,
HttpConnectionManager connectionManager) {
Review Comment:
Good catch! Made this change while trying an alternate way of implementing
reloadTable -- will remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
