shenyu0127 commented on code in PR #11220:
URL: https://github.com/apache/pinot/pull/11220#discussion_r1281246684
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/dociditerators/ExpressionScanDocIdIterator.java:
##########
@@ -212,8 +215,27 @@ private void processProjectionBlock(ProjectionBlock
projectionBlock, BitmapDataP
default:
throw new IllegalStateException();
}
+ if (_nullHandlingEnabled) {
+ RoaringBitmap nullBitmap =
_transformFunction.getNullBitmap(projectionBlock);
+ if (_predicateEvaluationResult == PredicateEvaluationResult.TRUE) {
+ if (nullBitmap != null) {
Review Comment:
This comment no longer applies. I now have an empty check in the `isNull`
function.
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/dociditerators/ExpressionScanDocIdIterator.java:
##########
@@ -85,7 +88,7 @@ public int next() {
ProjectionBlock projectionBlock =
new ProjectionOperator(_dataSourceMap, new
RangeDocIdSetOperator(blockStartDocId, _blockEndDocId))
.nextBlock();
- RoaringBitmap matchingDocIds = new RoaringBitmap();
+ MutableRoaringBitmap matchingDocIds = new MutableRoaringBitmap();
Review Comment:
Reverted the change.
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/dociditerators/ExpressionScanDocIdIterator.java:
##########
@@ -212,8 +215,27 @@ private void processProjectionBlock(ProjectionBlock
projectionBlock, BitmapDataP
default:
throw new IllegalStateException();
}
+ if (_nullHandlingEnabled) {
+ RoaringBitmap nullBitmap =
_transformFunction.getNullBitmap(projectionBlock);
Review Comment:
Good point. Fixed the bug.
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/dociditerators/ExpressionScanDocIdIterator.java:
##########
@@ -212,8 +215,27 @@ private void processProjectionBlock(ProjectionBlock
projectionBlock, BitmapDataP
default:
throw new IllegalStateException();
}
+ if (_nullHandlingEnabled) {
+ RoaringBitmap nullBitmap =
_transformFunction.getNullBitmap(projectionBlock);
+ if (_predicateEvaluationResult == PredicateEvaluationResult.TRUE) {
+ if (nullBitmap != null) {
+ RoaringBitmap fullBitmap = new RoaringBitmap();
+ fullBitmap.add(0L, (long) numDocs);
+ nullBitmap.xor(fullBitmap);
+ matchingDocIds.and(nullBitmap.toMutableRoaringBitmap());
Review Comment:
This comment no longer applies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
