walterddr commented on code in PR #11205:
URL: https://github.com/apache/pinot/pull/11205#discussion_r1280755616


##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/ReceivingMailbox.java:
##########
@@ -79,7 +94,11 @@ public boolean offer(TransferableBlock block, long 
timeoutMs) {
     try {
       if (_blocks.offer(block, timeoutMs, TimeUnit.MILLISECONDS)) {
         if (_errorBlock.get() == null) {
+          if (LOGGER.isDebugEnabled()) {
+            LOGGER.debug("==[MAILBOX]== Block " + block + " ready to read from 
mailbox: " + _id);
+          }
           _receiveMailCallback.accept(MailboxIdUtils.toOpChainId(_id));
+          notifyReader();

Review Comment:
   tagging @Jackie-Jiang to take a look at the mailbox mechanism



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to