walterddr commented on code in PR #11208:
URL: https://github.com/apache/pinot/pull/11208#discussion_r1280699265
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/LiteralHintUtils.java:
##########
@@ -46,13 +46,13 @@ public static String
literalMapToHintString(Map<Pair<Integer, Integer>, RexExpre
e.getValue().getDataType().name(), e.getValue().getValue()));
}
// semi-colon is used to separate between encoded literals
- return "{" + StringUtils.join(literalStrings, ";") + "}";
+ return "{" + StringUtils.join(literalStrings, ";:;") + "}";
Review Comment:
the problem is b/c in some agg literals it allows stringify parameter type
with `;` as the separator. this conflicts with my usage of `;` which indicates
the "next literal hint".
Thus i used another 3-character splitter `;:;` to indicate hint-literal
boundaries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
