shenyu0127 commented on PR #11188: URL: https://github.com/apache/pinot/pull/11188#issuecomment-1656532921
> Can you also check if we have proper behavior on `= NULL`, `!= NULL`, `> NULL` etc? Probably we should avoid explicit `NULL` in all the predicate? Good point. Changed the PR to avoid explicit `NULL` in all the predicates. > Please also add some description to the PR and some comment in the code explaining why we don't allow NULL in IN/NOT IN Added a function comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
