gortiz commented on PR #11205: URL: https://github.com/apache/pinot/pull/11205#issuecomment-1655552099
Important: Current commit does not support pipeline breaker. We are going to work on that during the next days. We don't expect to merge this PR before pipeline breaker is adapted to this new model. Most tests in pinot-query-runtime are working. I wasn't able to fix all tests in QueryRunnerTest. Some of them seem to relay on pipeline breaker, but there may be other bugs. For example, `OpChain._opChainFinishCallback` was added after made his fork, so I have to add changes in order to make these tests pass. I guess there may be more cases like that. Also, I've changed the way receive mailbox operator blocks when there all mailboxes are empty. Instead of waiting on a structure maintained by the opchain scheduler, now there is a direct lock between mailboxes and the operator. I decided to store that callback in MailboxService, which seems less intrusive than the scheduler, but we can debate about better options. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
