priyen commented on code in PR #10926:
URL: https://github.com/apache/pinot/pull/10926#discussion_r1275464930
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java:
##########
@@ -1211,17 +1230,29 @@ private static Map<String, Pair<String,
ValueAggregator>> fromAggregationConfig(
"aggregation function must be a function: %s", config);
FunctionContext functionContext = expressionContext.getFunction();
TableConfigUtils.validateIngestionAggregation(functionContext.getFunctionName());
- Preconditions.checkState(functionContext.getArguments().size() == 1,
- "aggregation function can only have one argument: %s", config);
+
Review Comment:
you're right, this is done in table utils, i'll remove it from here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
