saurabhd336 commented on code in PR #11128:
URL: https://github.com/apache/pinot/pull/11128#discussion_r1274842035


##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTenantRestletResource.java:
##########
@@ -103,6 +112,9 @@ public class PinotTenantRestletResource {
   @Inject
   ControllerMetrics _controllerMetrics;
 
+  @Inject
+  ExecutorService _executorService;

Review Comment:
   I'm not sure if using the same shared executorService (which is also being 
used to handle multi get API call responses) for parallelly running multiple 
blocking operation like table rebalance is a good idea.. Although I do see same 
executorService being used to run rebalance for single table.
   Thoughts?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to