[GitHub] [pinot] summerhasama-stripe commented on a diff in pull request #11073: For table rebalance, check if instances are equal for NO_OP

[via GitHub]

summerhasama-stripe commented on code in PR #11073:
URL: https://github.com/apache/pinot/pull/11073#discussion_r1268165609


##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##########
@@ -569,7 +585,7 @@ private InstancePartitions 
getInstancePartitions(TableConfig tableConfig,
         LOGGER.info("Removing instance partitions: {} from ZK if it exists", 
instancePartitionsName);
         
InstancePartitionsUtils.removeInstancePartitions(_helixManager.getHelixPropertyStore(),
 instancePartitionsName);
       }
-      return instancePartitions;
+      return Pair.of(instancePartitions, true);

Review Comment:
   So just to double check, if there are existing instance partitions then it 
should return true that the instancePartitionsUnchanged



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org