[pinot] branch master updated: Improve error message in case of throwables in multistage (#11103)

[xiangfu]

This is an automated email from the ASF dual-hosted git repository.

xiangfu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git


The following commit(s) were added to refs/heads/master by this push:
     new 2c3ea27f3b Improve error message in case of throwables in multistage 
(#11103)
2c3ea27f3b is described below

commit 2c3ea27f3b69c39efffc49de074847188234c6a1
Author: Pratik Tibrewal <tibrewalpra...@uber.com>
AuthorDate: Sat Jul 15 14:13:50 2023 +0530

    Improve error message in case of throwables in multistage (#11103)
    
    * Improve error message in QueryDispatcher
    
    * address comments
    
    * update in broker request handler
    
    * Update 
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java
    
    Co-authored-by: Rong Rong <ro...@apache.org>
    
    ---------
    
    Co-authored-by: Xiang Fu <xiangfu.1...@gmail.com>
    Co-authored-by: Rong Rong <ro...@apache.org>
---
 .../pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git 
a/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java
 
b/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java
index 37ff5f23fa..7328dacb8c 100644
--- 
a/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java
+++ 
b/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java
@@ -218,9 +218,9 @@ public class MultiStageBrokerRequestHandler extends 
BaseBrokerRequestHandler {
       queryResults = _queryDispatcher.submitAndReduce(requestId, 
dispatchableSubPlan, _mailboxService,
           _reducerScheduler,
           queryTimeoutMs, sqlNodeAndOptions.getOptions(), stageIdStatsMap, 
traceEnabled);
-    } catch (Exception e) {
-      LOGGER.info("query execution failed", e);
-      return new 
BrokerResponseNative(QueryException.getException(QueryException.QUERY_EXECUTION_ERROR,
 e));
+    } catch (Throwable t) {
+      LOGGER.error("query execution failed", t);
+      return new 
BrokerResponseNative(QueryException.getException(QueryException.QUERY_EXECUTION_ERROR,
 t));
     }
 
     BrokerResponseNativeV2 brokerResponse = new BrokerResponseNativeV2();


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org