abhioncbr commented on code in PR #11052:
URL: https://github.com/apache/pinot/pull/11052#discussion_r1263963868
##########
pinot-query-planner/src/test/java/org/apache/pinot/query/QueryEnvironmentTestBase.java:
##########
@@ -202,4 +205,10 @@ public String toString() {
}
}
}
+
+ // temporary function to strip the Physical plan from the explain query plan.
+ // physical plan is present for the explain queries by default.
Review Comment:
yes, by default it's setting `SqlExplain.Depth.PHYSICAL`.
Please check class `org.apache.calcite.sql.parser.impl.SqlParserImpl` method
`ExplainDepth()`, line number 5013. It's a generated file so I am missing the
link here. I did check the calcite project, it's the same for Babel and a
couple of other parsers impl.
That's why I was asking what type of default behaviour we want.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
