xiangfu0 commented on PR #10918: URL: https://github.com/apache/pinot/pull/10918#issuecomment-1627442279
> > I'm thinking of making data gen part of the integration test, and allow us to generate larger data sets for joins. We can make a separated CI check just for this TPC-H integration test. > > That'd be great. Are you planning to use tpc-h db-gen or are you planning to generate using custom Java code? Maybe java code is better, which means we can have a separated method in `TPCHQueryIntegrationTest` called `generateDataSet` and do nothing. Then have a new class `TPCHQueryLargeDataSetIntegrationTest`, which we just override this `generateDataSet` method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
