Jackie-Jiang commented on code in PR #11015:
URL: https://github.com/apache/pinot/pull/11015#discussion_r1248573641
##########
pinot-common/src/main/java/org/apache/pinot/common/datablock/BaseDataBlock.java:
##########
@@ -387,7 +387,10 @@ public RoaringBitmap getNullRowIds(int colId) {
*/
protected byte[] serializeStringDictionary()
throws IOException {
- ByteArrayOutputStream byteArrayOutputStream = new ByteArrayOutputStream();
+ if (_stringDictionary.length == 0) {
+ return new byte[]{0, 0, 0, 0};
Review Comment:
(minor) Equivalent to `new byte[4]`? Same for other places
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
