lucifer4j opened a new pull request, #11013: URL: https://github.com/apache/pinot/pull/11013
`feature` (partially fixes #10924). `ConnectionFactory` class is used to create instances on pinot client's `Connection` class. There are different methods available depending upon the kind of broker that we want to use. All of these except `fromController` also provide a variant to accept a `PinotClientTransport` from the user. We are wrapping around the `ConnectionFactory` class in the Vert.x wrapper for pinot client to provide our custom transport. Since the constructors of the `Connection` class are package-private, we cannot directly add this method to an external package. Further, this method seems to be absent from the class only as a mistake (there are methods to specify custom transports with all other brokers). Hence, adding this method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
