robertzych commented on code in PR #10463: URL: https://github.com/apache/pinot/pull/10463#discussion_r1244647288
########## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java: ########## @@ -489,14 +489,16 @@ static void setDefaultTimeValueIfInvalid(TableConfig tableConfig, Schema schema, @Override public void addSegment(ImmutableSegment immutableSegment) { - if (isUpsertEnabled()) { - handleUpsert(immutableSegment); - return; - } + if (immutableSegment instanceof ImmutableSegmentImpl) { Review Comment: Got it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org