klsince commented on code in PR #10977:
URL: https://github.com/apache/pinot/pull/10977#discussion_r1244334712
##########
pinot-core/src/main/java/org/apache/pinot/core/util/trace/BuiltInTracer.java:
##########
@@ -50,6 +50,15 @@ public void close() {
}
TraceContext.logTime(operatorName, duration);
}
+
+ @Override
+ public void close(Object context) {
+ String operatorName = _operator.getSimpleName();
+ if (LOGGER.isTraceEnabled()) {
Review Comment:
sry, missed this comment. I did this same way as in the close() method above.
I think it's unnecessary if not on very critical path, as only reference is
passed to trace() method. But this simple if-check may save cost of some method
calls, considering this span.close() is on query critical path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
