walterddr commented on code in PR #10873:
URL: https://github.com/apache/pinot/pull/10873#discussion_r1244098059
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/QueryEnvironment.java:
##########
@@ -208,6 +210,24 @@ public String explainQuery(String sqlQuery) {
return explainQuery(sqlQuery,
CalciteSqlParser.compileToSqlNodeAndOptions(sqlQuery)).getExplainPlan();
}
+ @VisibleForTesting
Review Comment:
this is visible for controller to use as well. so not correct annotation
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/BaseClusterIntegrationTestSet.java:
##########
@@ -156,7 +156,7 @@ private void testHardcodedQueriesCommon()
"SELECT ArrDelay, CarrierDelay, (ArrDelay - CarrierDelay) AS diff FROM
mytable WHERE ArrDelay > CarrierDelay "
+ "ORDER BY diff, ArrDelay, CarrierDelay LIMIT 100000";
testQuery(query);
- query = "SELECT count(*) FROM mytable WHERE AirlineID > 20355 AND
OriginState BETWEEN 'PA' AND 'DE' AND DepTime <> "
+ query = "SELECT count(*) FROM mytable WHERE AirlineID > 20355 AND
OriginState BETWEEN 'DE' AND 'PA' AND DepTime <> "
Review Comment:
revert please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
