jtao15 commented on code in PR #10964:
URL: https://github.com/apache/pinot/pull/10964#discussion_r1243289538
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/lineage/DefaultLineageManager.java:
##########
@@ -105,6 +107,11 @@ public void updateLineageForRetention(TableConfig
tableConfig, SegmentLineage li
}
}
+ @Override
+ public List<List<SegmentZKMetadata>>
getSegmentGroupsForMergeRollupTask(TableConfig tableConfig,
Review Comment:
@snleee @sajjad-moradi Thanks for the suggestion, removed from
`LineageManager` and added `PinotTaskSegmentGroupManager` interface. Custom
class can be registered via
`PinotTaskManager.registerTaskSegmentGroupManager()`. Please take another look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
