shenyu0127 commented on PR #10967: URL: https://github.com/apache/pinot/pull/10967#issuecomment-1608572593
Had an offline sync with @Jackie-Jiang , we will revert the change and make `TransformBlockValSet::getNullBitmap` return the cache. - For API design perspective, returning the cache is not ideal (client can modify the cache). We have control the package so it is ok. - For performance, we want to avoid making a copy. - For consistency, in Pinot we return cache/reference in many places (e.g. `BaseTransformFunction` returns `_intValuesSV`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
