shounakmk219 commented on code in PR #10905:
URL: https://github.com/apache/pinot/pull/10905#discussion_r1238640101
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/startree/v2/builder/MultipleTreesBuilder.java:
##########
@@ -136,9 +161,16 @@ public void build()
for (int i = 0; i < numStarTrees; i++) {
StarTreeV2BuilderConfig builderConfig = _builderConfigs.get(i);
Configuration metadataProperties =
_metadataProperties.subset(MetadataKey.getStarTreePrefix(i));
- try (SingleTreeBuilder singleTreeBuilder =
getSingleTreeBuilder(builderConfig, starTreeIndexDir, _segment,
- metadataProperties, _buildMode)) {
- singleTreeBuilder.build();
+ if (_existingStarTrees.containsTree(builderConfig)) {
Review Comment:
Updated the `handleExistingStarTreeAddition` to return boolean based on
whether the tree was reused, and moved all the check inside this function
itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
