mneedham opened a new pull request, #10961:
URL: https://github.com/apache/pinot/pull/10961

   I want to backfill segments into a real-time table, but the code in 
`SegmentGenerationUtils#getTableConfig` seems to be designed to only allow that 
for offline tables.
   
   The stub code in SegmentGenerationJobRunnerTest.java. doesn't properly 
reflect the actual values returned by the API. The stub returns:
   
   ```
   {
   "tableName": "events_rc_OFFLINE",
   "tableType": "OFFLINE",
   ...
   ```
   
   which misses the nesting that the API actually returns:
   
   ```
   {
   "OFFLINE": {
     "tableName": "events_rc_OFFLINE",
     "tableType": "OFFLINE",
   ```
   
   This PR updates those tests as well.
   
   I wasn't completely sure what to do if the user tries to upload a segment to 
a hybrid table without indicating if it should for the real-time or offline 
table, so we throw an exception in that case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to