snleee commented on code in PR #10463:
URL: https://github.com/apache/pinot/pull/10463#discussion_r1235512864
##########
pinot-core/src/main/java/org/apache/pinot/core/common/MinionConstants.java:
##########
@@ -136,4 +136,18 @@ public static class SegmentGenerationAndPushTask {
public static final String CONFIG_NUMBER_CONCURRENT_TASKS_PER_INSTANCE =
"SegmentGenerationAndPushTask.numConcurrentTasksPerInstance";
}
+
+ public static class UpsertCompactionTask {
+ public static final String TASK_TYPE = "UpsertCompactionTask";
+ /**
+ * The time period to wait before picking segments for this task
+ * e.g. if set to "2d", no task will be scheduled for a time window
younger than 2 days
+ */
+ public static final String BUFFER_TIME_PERIOD_KEY = "bufferTimePeriod";
+ /**
+ * The maximum percent of old records allowed for a completed segment.
+ * e.g. if the percent surpasses 30, then the segment will be compacted
+ */
+ public static final String INVALID_RECORDS_THRESHOLD_PERCENT =
"invalidRecordsThresholdPercent";
Review Comment:
@Jackie-Jiang @robertzych
This is a good point.
In that case, we can have 2 configurations : num Rows + percent.
We can put the default numRows to be some reasonable number (e.g. 100k)
Then, the compaction would trigger when both condition satisfies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
