walterddr commented on code in PR #10873:
URL: https://github.com/apache/pinot/pull/10873#discussion_r1233352886
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java:
##########
@@ -185,8 +190,10 @@ private String getMultiStageQueryResponse(String query,
String queryOptions, Htt
return QueryException.ACCESS_DENIED_ERROR.toString();
}
- SqlNodeAndOptions sqlNodeAndOptions = RequestUtils.parseQuery(query);
- List<String> tableNames =
CalciteSqlParser.extractTableNamesFromNode(sqlNodeAndOptions.getSqlNode());
Review Comment:
what's your thought on this @abhioncbr ? do you think we have a better way
to handle table look up? ideally speaking shouldn't keep this hacky SqlNode
parser level table finder b/c there's corner cases we can't really do on the
syntactic parsing level.
What i can think about is
- only allow simple broker selector if dealing with V2 engine queries for
now. (so there's no need to extract table name, we blindly select a broker)
- we should support controller based broker selector to ask controller to
return the broker --> this way we avoid the table metadata problem b/c
controller have access to all table metadata.
Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
