chenboat commented on code in PR #10915:
URL: https://github.com/apache/pinot/pull/10915#discussion_r1231674612
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/ConcurrentMapPartitionUpsertMetadataManager.java:
##########
@@ -243,6 +295,47 @@ protected GenericRow doUpdateRecord(GenericRow record,
RecordInfo recordInfo) {
}
}
+ protected long loadWatermark() {
+ File watermarkFile = getWatermarkFile();
+ if (watermarkFile.exists()) {
Review Comment:
NIT: code would be much easier to read if it is structured as
if (!wmf.exist()) {
return Long.MIN_VALUE;
}
....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
