soumitra-st opened a new pull request, #10904:
URL: https://github.com/apache/pinot/pull/10904

   BaseBrokerStarter Pinot creates _brokerAdminApplication object and starts it 
in the BaseBrokerStarter.start method, hence _brokerAdminApplication object is 
not accessible in derived classes of BaseBrokerStarter to register 
ContainerRequestFilter.
   
   This PR moves the initialization of _brokerAdminApplication in 
BaseBrokerStarter.start method, including its upstream dependencies to 
BaseBrokerStarter.init method. Below is a sample derived class to register a 
custom filter.
   
   public class MyBrokerStarter extends HelixBrokerStarter {
   ...
   @Override
     public void init(PinotConfiguration pinotConfiguration)
         throws Exception {
       super.init(pinotConfiguration);
       _brokerAdminApplication.register(MyBrokerFilter.class);
     }
   ...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to