swaminathanmanish commented on code in PR #10874: URL: https://github.com/apache/pinot/pull/10874#discussion_r1227354592
########## pinot-spi/src/main/java/org/apache/pinot/spi/data/readers/RecordReaderFileConfig.java: ########## @@ -0,0 +1,57 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.spi.data.readers; + +import java.io.File; +import java.util.Set; +import javax.annotation.Nullable; + + +/** + * Wraps RecordReader info to instantiate a reader. Users can either pass in the + * RecordReader instance directly or the info required to initialize the RecordReader, so that the + * RecordReader can be initialized just when its about to be used, which avoids early/eager + * initialization/memory allocation. + */ +public class RecordReaderFileConfig { Review Comment: Resolved offline that we will keep the same name. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
