abhioncbr opened a new issue, #10890: URL: https://github.com/apache/pinot/issues/10890
Labels: bugfix Recently, we introduced the `partitionColumn` field in config `ReplicaGroupPartitionConfig` and the validation logic. Here is the PR for [reference](https://github.com/apache/pinot/pull/10656) The [validation](https://github.com/apache/pinot/blob/master/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java#L616) checks that `ReplicaGroupPartitionConfig` and `ReplicaGroupStrategyConfig` should not be present for the table. For backward compatibility, we should ensure that validation fails only if both configs have a different value of `partitionColumn`; otherwise, not. Notes: - As per the [implementation](https://github.com/apache/pinot/blob/master/pinot-common/src/main/java/org/apache/pinot/common/utils/config/TableConfigUtils.java#L455), if both configs have the `partitionColumn` value, it will be picked from `ReplicaGroupPartitionConfig`. - This validation is to avoid confusion about the value used. cc: @Jackie-Jiang @tibrewalpratik17 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
