klsince commented on code in PR #10847:
URL: https://github.com/apache/pinot/pull/10847#discussion_r1218884702
##########
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/framework/SegmentProcessorFramework.java:
##########
@@ -91,33 +92,51 @@ public SegmentProcessorFramework(List<RecordReader>
recordReaders, SegmentProces
*/
public List<File> process()
throws Exception {
+ try {
+ return doProcess();
+ } catch (Exception e) {
+ if (_partitionToFileManagerMap != null) {
+ for (GenericRowFileManager fileManager :
_partitionToFileManagerMap.values()) {
+ fileManager.cleanUp();
+ }
+ }
+ throw new RuntimeException("Failed to complete process", e);
Review Comment:
updated to throw e directly, as the extra context msg passed to
RuntimeException didn't carry much info anway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
