gortiz commented on PR #10851: URL: https://github.com/apache/pinot/pull/10851#issuecomment-1577693842
It would be nice to add a test that verifies that the specified logic is fulfilled by the implementation, but I'm not sure about how to do that. Maybe we can create a segment with the index stored and then mock `SegmentDirectory.Reader.hasIndex` to return false? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
