swaminathanmanish commented on code in PR #10830: URL: https://github.com/apache/pinot/pull/10830#discussion_r1218665129
########## pinot-core/src/main/java/org/apache/pinot/core/segment/processing/mapper/SegmentMapper.java: ########## @@ -136,6 +136,7 @@ public Map<String, GenericRowFileManager> map() reuse.clear(); } + recordReader.close(); Review Comment: Can we release the reader resources here, after we are done processing the file ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org