klsince commented on code in PR #10837:
URL: https://github.com/apache/pinot/pull/10837#discussion_r1214941838


##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java:
##########
@@ -691,9 +691,10 @@ File getSegmentDataDir(String segmentName, @Nullable 
String segmentTier, TableCo
       File tierTableDataDir = new File(tierDataDir, _tableNameWithType);
       return new File(tierTableDataDir, segmentName);
     } catch (Exception e) {
-      LOGGER.warn("Failed to get dataDir for segment: {} of table: {} on tier: 
{} due to error: {}", segmentName,
-          _tableNameWithType, segmentTier, e.getMessage());
-      return getSegmentDataDir(segmentName);
+      File defaultDir = getSegmentDataDir(segmentName);
+      LOGGER.debug("Failed to get dataDir for segment: {} of table: {} on 
tier: {} due to error: {}. Use default: {}",

Review Comment:
   This is exception for TierBasedSegmentDirectoryLoader, which expects tier is 
backed by a data path and it logs a warn log itself. But it's a common case 
that a table has multi tiers backed by different server pools, which simply use 
the default dataDir to load segments via DefaultSegmentDirectoryLoader, i.e. no 
particular data path for the tiers. And because this is BaseTableDataManager 
class, so make this a debug log.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to