eaugene commented on code in PR #10812:
URL: https://github.com/apache/pinot/pull/10812#discussion_r1213287408
##########
pinot-controller/src/main/java/org/apache/pinot/controller/util/TableSizeReader.java:
##########
@@ -132,12 +144,19 @@ public TableSizeDetails getTableSizeDetails(@Nonnull
String tableName, @Nonnegat
}
}
if (largestSegmentSizeOnServer != DEFAULT_SIZE_WHEN_MISSING_OR_ERROR) {
- _controllerMetrics.setValueOfTableGauge(offlineTableName,
- ControllerGauge.LARGEST_SEGMENT_SIZE_ON_SERVER,
+ _controllerMetrics.setValueOfTableGauge(offlineTableName,
ControllerGauge.LARGEST_SEGMENT_SIZE_ON_SERVER,
largestSegmentSizeOnServer);
}
}
+ // Set the top level sizes to DEFAULT_SIZE_WHEN_MISSING_OR_ERROR when all
segments are error
+ if ((hasRealtimeTableConfig && hasOfflineTableConfig &&
isMissingAllRealtimeSegments && isMissingAllOfflineSegments)
Review Comment:
1. We would require this condition , else it would fail for hybrid table
case when All realtime segments are good, while all offline segments are
missing & vice versa case as well .
2. Explained the reason here :
https://github.com/apache/pinot/pull/10812/files#r1213281580 . It would be set
"-1" when all existing segments of the table are missing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
