shenyu0127 commented on code in PR #10613:
URL: https://github.com/apache/pinot/pull/10613#discussion_r1212367303
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/docvalsets/TransformBlockValSet.java:
##########
@@ -46,47 +45,23 @@ public class TransformBlockValSet implements BlockValSet {
private final TransformFunction _transformFunction;
private final ExpressionContext _expression;
- private boolean _nullBitmapSet;
- private RoaringBitmap _nullBitmap;
+ private RoaringBitmap _nullBitmap = null;
private int[] _numMVEntries;
+ private final boolean _isNullHandlingEnabled;
+
public TransformBlockValSet(ValueBlock valueBlock, TransformFunction
transformFunction,
- ExpressionContext expression) {
+ ExpressionContext expression, boolean isNullHandlingEnabled) {
_valueBlock = valueBlock;
_transformFunction = transformFunction;
_expression = expression;
+ _isNullHandlingEnabled = isNullHandlingEnabled;
}
@Nullable
@Override
public RoaringBitmap getNullBitmap() {
Review Comment:
We only need to address this comment, the other comments are nit-picks and
optional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
