abhioncbr commented on code in PR #10814:
URL: https://github.com/apache/pinot/pull/10814#discussion_r1210931175
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/BinaryOperatorTransformFunction.java:
##########
@@ -422,6 +422,11 @@ private void fillLongResultArray(ValueBlock valueBlock,
float[] leftValues, int
}
private void fillFloatResultArray(ValueBlock valueBlock, float[] leftValues,
int length) {
+ // handling float double comparison, skipping the right CAST function and
evaluate the result.
Review Comment:
This solution can only handle float-double comparison in the `SELECT`
clause. Not able to handle similar comparisons in the `WHERE` clause.
I am looking for a better approach to handle both scenarios.
@Jackie-Jiang @walterddr Do you think float-double comparison can occur in
some other SQL clause?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
