ankitsultana commented on code in PR #10794:
URL: https://github.com/apache/pinot/pull/10794#discussion_r1202507747


##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/dispatch/QueryDispatcher.java:
##########
@@ -231,6 +232,9 @@ private static List<DataBlock> 
reduceMailboxReceive(MailboxReceiveOperator mailb
             "Received error query execution result block: " + 
transferableBlock.getDataBlock().getExceptions());
       }
       if (transferableBlock.isNoOpBlock()) {
+        // If all mailbox return no-op block, then we sleep for some time 
before retrying. This can increase the latency
+        // of the query a little bit but it will prevent the broker from 
running into a busy-waiting loop.
+        Thread.sleep(10);

Review Comment:
   Until we have that approach finalized, can we merge this to fix master?
   
   We can revert this and fix this properly with the pipeline breaker PR?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to