walterddr commented on code in PR #10789:
URL: https://github.com/apache/pinot/pull/10789#discussion_r1201466858
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java:
##########
@@ -69,13 +71,15 @@
public class MultiStageBrokerRequestHandler extends BaseBrokerRequestHandler {
private static final Logger LOGGER =
LoggerFactory.getLogger(MultiStageBrokerRequestHandler.class);
+ private final Random _random = new Random();
Review Comment:
had some offline discussion, can we do something like
```
requestID = ((Long)((hash(brokerId) << 32)) +
_requestIdGenerator.incrementAndGet()
```
encode brokerID and requestID with high/low bits?
this way we can still masked out the lower bit to get the exact ordering of
the requests when we look at the requestID. this will be better in terms of
debuggability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
