jackjlli commented on code in PR #10777: URL: https://github.com/apache/pinot/pull/10777#discussion_r1200829713
########## pinot-common/src/main/java/org/apache/pinot/common/utils/fetcher/BaseSegmentFetcher.java: ########## @@ -102,7 +104,8 @@ public void fetchSegmentToLocal(List<URI> uris, File dest) }); } - public File fetchUntarSegmentToLocalStreamed(URI uri, File dest, long rateLimit) + public File fetchUntarSegmentToLocalStreamed(URI uri, File dest, long rateLimit, + AtomicInteger attempts) Review Comment: Now that we record the attempts for this signature. Do we plan to add this attempt to the other one(s) as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org