abhioncbr commented on code in PR #10790:
URL: https://github.com/apache/pinot/pull/10790#discussion_r1199774793
##########
pinot-common/src/main/java/org/apache/pinot/common/function/FunctionRegistry.java:
##########
@@ -205,5 +205,15 @@ public static boolean textMatch(String text, String
pattern) {
public static boolean jsonMatch(String text, String pattern) {
throw new UnsupportedOperationException("Placeholder scalar function,
should not reach here");
}
+
+ @ScalarFunction(names = {"split", "split"}, isPlaceholder = true)
Review Comment:
With this change, we can handle the `split` function in multistage.
The other option available is to leave it as it is i.e. returning
`string[]`. In that case, it will translate to `SqlTypeName.OTHER` and
eventually become `DataSchema.ColumnDataType.OBJECT`. To get it working we need
to add support in `ObjectSerDeUtils` for `string[]`.
Currently, it's following the above-mentioned option and failing with an
exception getting generated from `ObjectSerDeUtils`
```
throw new IllegalArgumentException("Unsupported type of value: " +
value.getClass().getSimpleName());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
