deemoliu commented on code in PR #10047:
URL: https://github.com/apache/pinot/pull/10047#discussion_r1199492928
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/PartitionUpsertMetadataManager.java:
##########
@@ -84,6 +84,16 @@ public interface PartitionUpsertMetadataManager extends
Closeable {
*/
GenericRow updateRecord(GenericRow record, RecordInfo recordInfo);
+ /**
+ * Remove from the primary key index when the PK are expired if TTL is
enabled.
+ */
+ void removeExpiredPrimaryKeys(Comparable expiredTimestamp);
+
+ /**
+ * Persist validDocIds snapshot when the validDocIds is stable if TTL is
enabled.
+ */
+ void persistSnapshotForStableSegments(long expiredTimestamp);
+
Review Comment:
@navina The comparison column value is a comparable, in the primaryKey to
recordLocation map.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
