walterddr commented on code in PR #10761: URL: https://github.com/apache/pinot/pull/10761#discussion_r1194033517
########## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/QueryRunner.java: ########## @@ -118,6 +122,7 @@ public void init(PinotConfiguration config, InstanceDataManager instanceDataMana getQueryWorkerIntermExecutorService()); _leafScheduler = new OpChainSchedulerService(new RoundRobinScheduler(releaseMs), getQueryRunnerExecutorService()); _mailboxService = new MailboxService(_hostname, _port, config, _intermScheduler::onDataAvailable); + _exchangeService = new ExchangeService(_hostname, _port, config); Review Comment: i am not sure this should be a separate service or should we put together with mailbox. b/c ultimately this is submitting a thread to poll data out of the exchange queue and sending data via GRPC or in-mem mailboxes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org