mcvsubbu commented on code in PR #10766:
URL: https://github.com/apache/pinot/pull/10766#discussion_r1193904441
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/helix/HelixHelper.java:
##########
@@ -163,6 +169,31 @@ public Boolean call() {
return true;
}
}
+
+ private boolean shouldCompress(IdealState is) {
+ if (is.getNumPartitions() >
NUM_PARTITIONS_THRESHOLD_TO_ENABLE_COMPRESSION) {
+ return true;
+ }
+
+ // Find the number of characters in one partition in idealstate, and
extrapolate
+ // to estimate the number of characters.
+ Iterator<String> it = is.getPartitionSet().iterator();
Review Comment:
> Also, according to the name from the variable
(`MIN_NUM_CHARS_IN_IS_TO_TURN_ON_COMPRESSION`), it doesn't exclude the rest of
the fields though.
That is correct. I could not come up with another name though :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
