walterddr commented on code in PR #10760:
URL: https://github.com/apache/pinot/pull/10760#discussion_r1193013446
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/MailboxSendOperator.java:
##########
@@ -128,21 +129,21 @@ protected TransferableBlock getNextBlock() {
TransferableBlock transferableBlock;
try {
transferableBlock = _sourceOperator.nextBlock();
- while (!transferableBlock.isNoOpBlock()) {
- if (transferableBlock.isEndOfStreamBlock()) {
- if (transferableBlock.isSuccessfulEndOfStreamBlock()) {
- //Stats need to be populated here because the block is being sent
to the mailbox
- // and the receiving opChain will not be able to access the stats
from the previous opChain
- TransferableBlock eosBlockWithStats =
TransferableBlockUtils.getEndOfStreamTransferableBlock(
-
OperatorUtils.getMetadataFromOperatorStats(_opChainStats.getOperatorStatsMap()));
- _exchange.send(eosBlockWithStats);
- } else {
- _exchange.send(transferableBlock);
- }
- return transferableBlock;
+ if (transferableBlock.isNoOpBlock()) {
+ return transferableBlock;
+ } else if (transferableBlock.isEndOfStreamBlock()) {
+ if (transferableBlock.isSuccessfulEndOfStreamBlock()) {
Review Comment:
yes you are correct. code-wise they are identical. here i just separate them
to distinguish signal block vs. data block for readability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
