[GitHub] [pinot] shounakmk219 commented on a diff in pull request #10757: Improvements on the utility to convert table config to updated format

[via GitHub]

shounakmk219 commented on code in PR #10757:
URL: https://github.com/apache/pinot/pull/10757#discussion_r1191110079


##########
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/dictionary/DictionaryIndexTypeTest.java:
##########
@@ -224,27 +224,48 @@ public void newVarLength()
     }
 
     @Test
-    public void oldToNewConfConversion()
+    public void oldToNewConfConversionWithOnHeap()
         throws IOException {
-      _tableConfig.getIndexingConfig().setNoDictionaryColumns(
-          JsonUtils.stringToObject("[\"dimInt\"]", _stringListTypeRef)
-      );
       _tableConfig.getIndexingConfig()
           .setOnHeapDictionaryColumns(JsonUtils.stringToObject("[\"dimInt\"]", 
_stringListTypeRef));
+      convertToUpdatedFormat();
+      FieldConfig fieldConfig = getFieldConfigByColumn("dimInt");
+      assertNotNull(fieldConfig.getIndexes().get(new 
DictionaryIndexType().getPrettyName()));

Review Comment:
   Nice catch, I even missed the use var length check below.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org