siddharthteotia commented on code in PR #10636:
URL: https://github.com/apache/pinot/pull/10636#discussion_r1188170065
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/AggregationFunctionType.java:
##########
@@ -94,7 +95,15 @@ public enum AggregationFunctionType {
// boolean aggregate functions
BOOLAND("boolAnd"),
- BOOLOR("boolOr");
+ BOOLOR("boolOr"),
+
+ // argMin and argMax
+ ARGMIN("argMin"),
+ ARGMAX("argMax"),
+
PINOTPARENTAGGREGATIONARGMIN(CommonConstants.RewriterConstants.PARENT_AGGREGATION_NAME_PREFIX
+ ARGMIN.getName()),
+
PINOTPARENTAGGREGATIONARGMAX(CommonConstants.RewriterConstants.PARENT_AGGREGATION_NAME_PREFIX
+ ARGMAX.getName()),
+
PINOTCHILDAGGREGATIONARGMIN(CommonConstants.RewriterConstants.CHILD_AGGREGATION_NAME_PREFIX
+ ARGMIN.getName()),
+
PINOTCHILDAGGREGATIONARGMAX(CommonConstants.RewriterConstants.CHILD_AGGREGATION_NAME_PREFIX
+ ARGMAX.getName());
Review Comment:
Main reason is clean interface. AggregationFunctionType is for user exposed
in-built functions ideally.
So as a follow-up we should try to see how we can do this cleanly in future
otherwise this file will end up having mix of things imo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
