ankitsultana commented on code in PR #10725:
URL: https://github.com/apache/pinot/pull/10725#discussion_r1187828148
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -606,6 +607,10 @@ private void commitSegmentMetadataInternal(String
realtimeTableName,
// Trigger the metadata event notifier
_metadataEventNotifierFactory.create().notifyOnSegmentFlush(tableConfig);
+
+ if (StringUtils.isBlank(committingSegmentDescriptor.getSegmentLocation()))
{
+ _controllerMetrics.addMeteredTableValue(realtimeTableName,
ControllerMeter.SEGMENT_MISSING_DEEP_STORE_LINK, 1);
+ }
Review Comment:
It can be different. In Split commit servers upload the file to a temp
location, and the file is atomically moved to the final location in the
controller. It could be that different replicas try to upload the segment to
the deep-store.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
